Fix Storybook Build running out of memory #7520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses memory-related issues in the build process and makes minor code readability improvements.
- Increased Node.js process memory limit from 6000MB to 8000MB in
packages/twenty-front/project.jsonfor the 'storybook:build' target - Added empty lines for improved readability in
packages/twenty-front/src/modules/workflow/components/WorkflowEditActionFormSendEmail.tsx - Changes aim to prevent 'JavaScript heap out of memory' errors during builds
- Modification may impact system resources and build performance
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
packages/twenty-front/project.json
Outdated
| @@ -67,7 +67,7 @@ | |||
| "test": {}, | |||
| "storybook:build": { | |||
| "options": { | |||
| "env": { "NODE_OPTIONS": "--max_old_space_size=6000" } | |||
| "env": { "NODE_OPTIONS": "--max_old_space_size=8000" } | |||
There was a problem hiding this comment.
This is a lot of RAM, I have already investigated it and the solution is to split the project into pieces OR lazy loading strategy on some app branches (already done for Settings)
charlesBochet
approved these changes
Oct 9, 2024
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Increases the node process memory to avoid `FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory` errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases the node process memory to avoid
FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memoryerrors