fix: date-picker overflow #7514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses the date-picker overflow issue across all screen sizes, focusing on the DateInput component in the Twenty frontend.
- Removed absolute positioning and top property from StyledCalendarContainer in DateInput.tsx
- Prevents date picker from clipping through navigation bar in mobile views
- Improves date picker positioning and visibility across different screen sizes
- Resolves issue Date picker clips through navigation bar in mobile #7014 where the date picker was overlapping with other UI elements
- Minor import order changes made, but these do not affect functionality
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
charlesBochet
approved these changes
Oct 9, 2024
|
Awarding harshrajeevsingh: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/harshrajeevsingh |
|
Thanks @harshrajeevsingh for your contribution! |
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Fixes twentyhq#7014 This PR fixes date-picker overflow across all screen sizes. **Before:**  **After:** [Screencast from 2024-10-08 23-41-36.webm](https://github.com/user-attachments/assets/a02c2866-8784-4e19-b914-ac3e97512dce)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7014
This PR fixes date-picker overflow across all screen sizes.
Before:
After:
Screencast from 2024-10-08 23-41-36.webm