Fix create task #7498
Merged
Fix create task #7498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses an issue with creating tasks introduced by a previous PR, focusing on improving loading states and error handling in the record creation process. Here are the key changes:
- Modified useOpenCreateActivityDrawer to set loading state before opening the right drawer, enhancing user experience
- Improved error handling and loading state management in RightDrawerRecord component for undefined object names and record IDs
- Simplified RecordShowContainer by replacing isNewViewableRecordLoadingState with a new prop isNewRightDrawerItemLoading
- Enhanced value handling in useRecordShowPage hook for better management of undefined or falsy values
- Conditional rendering of RecordValueSetterEffect based on loading state in RightDrawerRecord
These changes collectively aim to fix the task creation issue and improve the overall robustness of the record creation and loading process.
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| <RecordValueSetterEffect recordId={objectRecordId} /> | ||
| {!isNewViewableRecordLoading && ( | ||
| <RecordValueSetterEffect recordId={objectRecordId} /> | ||
| )} | ||
| <RecordShowContainer | ||
| objectNameSingular={objectNameSingular} | ||
| objectRecordId={objectRecordId} | ||
| loading={false} |
There was a problem hiding this comment.
logic: The loading prop is set to false, but isNewRightDrawerItemLoading is used. Ensure this doesn't cause inconsistent loading states
thomtrp
approved these changes
Oct 8, 2024
|
LGTM |
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Fixing issue introduced by [Add Skeleton loading for side panel](https://github.com/twentyhq/twenty/pull/7394/files#top): https://github.com/user-attachments/assets/6c8e299c-d663-4aa7-83ed-ca7041cd15e7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue introduced by Add Skeleton loading for side panel:
https://github.com/user-attachments/assets/6c8e299c-d663-4aa7-83ed-ca7041cd15e7