Fix advanced settings animation #7497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses the advanced settings animation in the settings navigation drawer, focusing on layout improvements and animation refinement. Key changes include:
- Modified SettingsNavigationDrawerItems.tsx to enhance visual consistency and spacing
- Adjusted StyledIconContainer height from 90% to 75% for better proportions
- Removed 'overflow' property from useExpandedHeightAnimation.tsx, simplifying animation logic
- Streamlined NavigationDrawer.tsx by removing gap and overflow-y properties from StyledItemsContainer
- Replaced NavigationDrawerSection with custom StyledNavigationDrawerSection for improved margin control
These changes aim to improve the overall user experience and visual appeal of the settings navigation drawer, particularly during animations and transitions.
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
| @@ -6,15 +6,11 @@ const transitionValues = { | |||
| opactity: { duration: 0.2 }, | |||
There was a problem hiding this comment.
syntax: 'opactity' is misspelled. Should be 'opacity'.
Comment on lines
25
to
27
| opacity: 1, | ||
| height: isExpanded ? measuredHeight : 0, | ||
| ...transitionValues, |
There was a problem hiding this comment.
style: Removing 'overflow: hidden' may cause content to visibly overflow during animation.
ijreilly
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title