Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #7486 enable save button on adding options in select/multiselect #7495

Conversation

NitinPSingh
Copy link
Contributor

issue : #7486

demo

08.10.2024_18.04.53_REC.mp4

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses issue #7486 by enabling the save button when adding options to select/multiselect fields in the SettingsDataModelFieldSelectForm component.

  • Modified handleAddOption and handleInputEnter functions to include { shouldDirty: true } when calling setFormValue
  • Ensures form is marked as dirty when new options are added, allowing users to save changes after only pressing 'Add option'
  • Change affects the form's dirty state, potentially impacting parent components that handle saving form data
  • Improves user experience by enabling the save functionality immediately after adding new options

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@charlesBochet charlesBochet merged commit 855060a into twentyhq:main Oct 9, 2024
11 checks passed
Copy link

github-actions bot commented Oct 9, 2024

Thanks @NitinPSingh for your contribution!
This marks your 5th PR on the repo. You're top 5% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants