Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #7486 trigger shouldDirty on adding new options #7494

Closed
wants to merge 3 commits into from

Conversation

NitinPSingh
Copy link
Contributor

issue: #7486

fix
added { shouldDirty: true }

demo:

08.10.2024_18.04.53_REC.mp4

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses issue #7486 by modifying the SettingsDataModelFieldSelectForm component to properly mark the form as dirty when adding new options.

  • Added { shouldDirty: true } to setFormValue calls in handleAddOption and handleInputEnter functions
  • Updated default values for Google and Microsoft authentication callback URLs in environment variable configurations
  • These changes enable the save button when new options are added to select/multiselect fields
  • The solution is straightforward and effectively resolves the reported issue without introducing new problems

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@NitinPSingh NitinPSingh closed this Oct 8, 2024
@NitinPSingh NitinPSingh deleted the disabled-save-button branch October 8, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant