fix: Developers page is not optimised for mobile viewport #7493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request optimizes the Developers page for mobile viewports, addressing overflow issues in the API keys and webhooks tables.
- Added responsive styling to
SettingsApiKeysTable.tsxusing media queries for better mobile layout - Implemented
useIsMobilehook inSettingsDevelopers.tsxfor conditional rendering on mobile devices - Created
StyledContainercomponent with mobile-specific styling to improve overall page layout - Adjusted grid template columns in
StyledTableRowfor better content display on smaller screens - Modified
StyledTableBodyto use flex display on mobile, enhancing table responsiveness
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
+20
to
+24
| } | ||
| `; | ||
|
|
||
| const StyledContainer = styled.div<{ isMobile: boolean }>` | ||
| display: flex; |
There was a problem hiding this comment.
style: StyledContainer doesn't use isMobile prop. Consider using it for mobile-specific styling
|
/oss.gg 150 |
|
Thanks for opening an issue! It's live on oss.gg! |
|
Awarding harshit078: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/harshit078 |
|
Thanks @harshit078 for your contribution! |
harshit078
added a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
) ## Description - This PR solves the issue twentyhq#7483 - optimised the developers page for all mobile viewports --------- Co-authored-by: Charles Bochet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description