Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hover advanced settings #7488

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fix hover advanced settings #7488

merged 1 commit into from
Oct 8, 2024

Conversation

thomtrp
Copy link
Contributor

@thomtrp thomtrp commented Oct 8, 2024

Capture d’écran 2024-10-08 à 12 12 59

greptile-apps[bot]
greptile-apps bot reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request modifies the NavigationDrawerSection component to improve the hover behavior for advanced settings in the navigation drawer.

  • Added width: 100%; to StyledSection in packages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawerSection.tsx to ensure full-width sections
  • This change likely addresses inconsistent hover areas for navigation items, particularly in the advanced settings section

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@thomtrp thomtrp merged commit 66ec70f into main Oct 8, 2024
13 checks passed
@thomtrp thomtrp deleted the tt-set-navigation-drawer-section-to-max-witdth branch October 8, 2024 11:36
harshit078 pushed a commit to harshit078/twenty that referenced this pull request Oct 14, 2024
@thomtrp @harshit078
Fix hover advanced settings (twentyhq#7488)
cbbea54 
<img width="264" alt="Capture d’écran 2024-10-08 à 12 12 59"
src="https://github.com/user-attachments/assets/a01621ef-d7e8-44d1-b301-9579ab632a60">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@ijreilly ijreilly ijreilly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomtrp @ijreilly