Fixes on messaging and calendar #7485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/twenty-front/src/testing/mock-data/generated/mock-metadata-query-result.ts
Show resolved
Hide resolved
.../src/modules/calendar/calendar-event-import-manager/services/calendar-save-events.service.ts
Outdated
Show resolved
Hide resolved
charlesBochet
approved these changes
Oct 8, 2024
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request implements changes to the calendar and messaging data models, focusing on improving sync functionality and data consistency. Here are the key modifications:
- Moved 'recurringEventExternalId' from CalendarEventWorkspaceEntity to CalendarChannelEventAssociationWorkspaceEntity
- Added 'syncedAt' field to CalendarChannelWorkspaceEntity and MessageChannelWorkspaceEntity
- Updated CalendarSaveEventsService to reflect new data model changes
- Modified seed data and standard field IDs to align with the new structure
- Adjusted types in calendar-event.ts to include 'recurringEventExternalId' where necessary
These changes aim to enhance the accuracy of event tracking across different calendar channels and improve sync status monitoring for both calendar and messaging functionalities.
10 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Fix syncedAt no longer been set on message sync. Fix calendar data model: - Add `syncedAt` to `CalendarChannelWorkspaceEntity` - Move `recurringEventExternalId` from `CalendarEventWorkspaceEntity` to `CalendarChannelEventAssociationWorkspaceEntity` since the id is relative to one channel Fix save queries on calendar sync after regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix syncedAt no longer been set on message sync.
Fix calendar data model:
syncedAttoCalendarChannelWorkspaceEntityrecurringEventExternalIdfromCalendarEventWorkspaceEntitytoCalendarChannelEventAssociationWorkspaceEntitysince the id is relative to one channelFix save queries on calendar sync after regression.