Fix restApi should not use TS_VECTOR fields as mutation inputs #7484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses an issue with the REST API handling of TS_VECTOR fields in mutation inputs.
- Added a check for FieldMetadataType.TS_VECTOR in
getSchemaComponentsPropertiesfunction in/packages/twenty-server/src/engine/core-modules/open-api/utils/components.utils.ts - Prevents TS_VECTOR fields from being included as mutation inputs in the REST API
- Improves API functionality by avoiding potential errors when interacting with TS_VECTOR fields
- Aligns the REST API behavior with the expected handling of search vector fields
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
ijreilly
approved these changes
Oct 8, 2024
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
…yhq#7484) ## Context <img width="398" alt="Screenshot 2024-10-08 at 11 10 59" src="https://github.com/user-attachments/assets/03ee0305-527c-42ed-a8a1-0ccea8176357"> <img width="489" alt="Screenshot 2024-10-08 at 11 10 50" src="https://github.com/user-attachments/assets/1403876b-40b6-490e-8557-d8280c439d57"> Tested with https://twenty.com/developers/rest-api/core#/operations/createOnePerson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Tested with https://twenty.com/developers/rest-api/core#/operations/createOnePerson