Rename typeorm metadata table #7473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request renames the TypeORM metadata table to '_typeorm_generated_columns_and_materialized_views' and introduces a new migration to create this table, addressing issue #7453 which requested dropping the 'typeorm_metadata' table and handling generated columns differently.
- Modified
core.datasource.tsto include 'metadataTableName' option in TypeORM configuration - Added new migration file
1728314605995-add_typeormGeneratedColumnsAndMaterializedViews.tsto create the renamed metadata table - Removed old migration file
1726848397026-addTypeOrmMetadata.ts - Updated
typeorm.service.tsto use the new metadata table name in DataSource configuration
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| public async up(queryRunner: QueryRunner): Promise<void> { | ||
| await queryRunner.query(` | ||
| CREATE TABLE "core"."_typeorm_generated_columns_and_materialized_views" ( | ||
| "type" character varying NOT NULL, |
There was a problem hiding this comment.
style: Define specific character varying length for 'type' column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7453