[Search] Fix tests #7471
Merged
[Search] Fix tests #7471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request modifies the WorkspaceModule and WorkspaceService to use FeatureFlagService instead of directly accessing FeatureFlagEntity.
- Removed FeatureFlagEntity from NestjsQueryTypeOrmModule in
packages/twenty-server/src/engine/core-modules/workspace/workspace.module.ts - Updated
packages/twenty-server/src/engine/core-modules/workspace/services/workspace.service.spec.tsto use FeatureFlagService instead of FeatureFlagEntity - Added FeatureFlagService provider in the test file, replacing the FeatureFlagEntity repository token
- These changes align the workspace module with the FeatureFlagService architecture, potentially improving modularity and encapsulation
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
thomtrp
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.