Add delete name column from standard object tables #7470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request introduces a new command to delete the 'name' column from standard object tables in existing workspaces as part of the upgrade process to version 0.31.
- Added
DeleteNameColumnStandardObjectTablesCommandinpackages/twenty-server/src/database/commands/upgrade-version/0-31/0-31-delete-name-column-standard-object-tables.command.ts - Integrated new command into
UpgradeTo0_31Commandexecution flow inpackages/twenty-server/src/database/commands/upgrade-version/0-31/0-31-upgrade-version.command.ts - Updated
UpgradeTo0_31CommandModuleto include the new command inpackages/twenty-server/src/database/commands/upgrade-version/0-31/0-31-upgrade-version.module.ts - Command checks for existing 'name' column and field metadata before deletion, with dry run option and error handling
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
+72
to
+75
| const nameColumnExists = await queryRunner?.hasColumn( | ||
| standardObject.nameSingular, | ||
| 'name', | ||
| ); |
There was a problem hiding this comment.
logic: Ensure queryRunner is not null before using optional chaining
ijreilly
approved these changes
Oct 7, 2024
| continue; | ||
| } | ||
|
|
||
| if (!nameColumnExists) { |
There was a problem hiding this comment.
is there a usecase in which we expect to have the fieldMetadata but not the column? or would that just not be our problem here
There was a problem hiding this comment.
Good point however that shouldn't be possible or at least that should be part of the sync-metadata health-check (which is broken though...)
Weiko
deleted the
c--add-delete-name-column-standard-object-tables-command
branch
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Following this twentyhq#7428 we now need to fix existing workspaces thanks to this migration command. This command will fetch all standard objects and their fields then filter out tables that don't have that column OR objects that have an existing fieldMetadata "name" of type TEXT and delete the rest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this #7428 we now need to fix existing workspaces thanks to this migration command.
This command will fetch all standard objects and their fields then filter out tables that don't have that column OR objects that have an existing fieldMetadata "name" of type TEXT and delete the rest.