-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hide calender icon if no deadline on task #7465
Fix hide calender icon if no deadline on task #7465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request addresses the issue of displaying a calendar icon for tasks without deadlines. The main changes are focused on improving the task display in the Twenty front-end application.
- Modified
TaskRow.tsx
to conditionally render the calendar icon and due date only whentask.dueAt
is present - Adjusted layout in
SettingsApiKeysFieldItemTableRow.tsx
,SettingsApiKeysTable.tsx
, andSettingsDevelopersWebhookTableRow.tsx
for improved responsiveness - Updated grid template columns in settings components to use more flexible layouts
- Removed unnecessary React import in
SettingsDevelopersWebhookTableRow.tsx
These changes enhance the user interface by removing visual clutter and improving the overall layout of various components in the application.
4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
} | ||
> | ||
<IconCalendar size={theme.icon.size.md} /> | ||
{task.dueAt && beautifyExactDate(task.dueAt)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Redundant check for task.dueAt, as it's already verified in the conditional rendering
...twenty-front/src/modules/settings/developers/components/SettingsApiKeysFieldItemTableRow.tsx
Outdated
Show resolved
Hide resolved
@Vardhaman619, could you move the due date to the left of the relation field on the card? |
@Bonapara Done 👍 |
Could u fix the conflicts @Vardhaman619? or do you need help? |
…con-if-no-deadline-on-task
@ehconitin I really want to fix this conflict, but I'm not sure where to start. Could you please outline the steps and processes I should follow to resolve it? Your guidance would be really helpful. |
@Vardhaman619 We merged your previous PR #7438 yesterday, but for some reason same changes were included in this PR as well. The merged changes differ slightly from what you’ve added here, so I’ve removed those redundant changes to resolve the conflicts. |
…con-if-no-deadline-on-task
@ehconitin Thank you for handling the conflicts and for the helpful advice! I'll make sure to keep my branch up to date with the upstream branch more frequently to avoid such issues in the future. Thanks |
…con-if-no-deadline-on-task
@Bonapara instead of showing due date after task target, should we show it before? due date before task target - |
@ehconitin yes we should show it before! |
Awarding Vardhaman619: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/Vardhaman619 |
Thanks @Vardhaman619 for your contribution! |
Closes twentyhq#7402 ![image](https://github.com/user-attachments/assets/46912a22-8dfb-4065-a877-de179fd796d3) Ensured that the calendar icon is only visible when a deadline is assigned --------- Co-authored-by: ehconitin <[email protected]>
Closes #7402
Ensured that the calendar icon is only visible when a deadline is assigned