Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Settings card inconsitent for mobile viewports #7464

Merged
merged 4 commits into from
Oct 10, 2024
Merged

fix: Settings card inconsitent for mobile viewports #7464

merged 4 commits into from
Oct 10, 2024

Conversation

harshit078
Copy link
Contributor

@harshit078 harshit078 commented Oct 7, 2024 •
edited by lucasbordeau
Loading

Closes #7457

greptile-apps[bot]
greptile-apps bot reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses a mobile viewport inconsistency in the Settings/Accounts section, improving the layout for smaller screens.

  • Modified packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsSettingsSection.tsx to add flex-direction: column to StyledCardsContainer
  • Change ensures consistent card width across all viewport sizes, fixing the issue reported in Settings card inconsitent for mobile viewports #7457
  • Improves mobile user experience by maintaining a uniform layout for settings cards

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@lucasbordeau lucasbordeau merged commit 43a0006 into twentyhq:main Oct 10, 2024
11 checks passed
@github-actions GitHub Actions
Copy link

Thanks @harshit078 for your contribution!
This marks your 30th PR on the repo. You're top 2% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@lucasbordeau lucasbordeau lucasbordeau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings card inconsitent for mobile viewports
2 participants
@harshit078 @lucasbordeau