Add missing currencies #7441
Add missing currencies #7441
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request significantly expands the currency support in the application, addressing issue #7038 by adding a comprehensive list of world currencies.
- Added 153 currency codes to the CurrencyCode enum in
packages/twenty-front/src/modules/object-record/record-field/types/CurrencyCode.ts - Expanded
SETTINGS_FIELD_CURRENCY_CODESinpackages/twenty-front/src/modules/settings/data-model/constants/SettingsFieldCurrencyCodes.tswith new currency codes, labels, and icons - Introduced numerous new currency icons in
packages/twenty-ui/src/display/icon/components/TablerIcons.ts - Corrected existing currency representations, such as updating the Thai Baht code from 'BHT' to 'THB'
3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings
packages/twenty-front/src/modules/object-record/record-field/types/CurrencyCode.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/data-model/constants/SettingsFieldCurrencyCodes.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/data-model/constants/SettingsFieldCurrencyCodes.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/data-model/constants/SettingsFieldCurrencyCodes.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks @BOHEUS
I'm back to code review after spending a lot of time on the tests :)
Left a few comments!
|
@charlesBochet I've answered your comments, please take a look in free time |
packages/twenty-front/src/modules/settings/data-model/constants/SettingsFieldCurrencyCodes.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/data-model/constants/SettingsFieldCurrencyCodes.ts
Outdated
Show resolved
Hide resolved
|
@BOHEUS TY, I have answered :) |
|
@charlesBochet done |
|
Thanks @BOHEUS for your contribution! |
|
/award 150 |
|
Awarding BOHEUS: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/BOHEUS |
Related to twentyhq#7038 --------- Co-authored-by: Charles Bochet <[email protected]>
Related to #7038