changed the createdByName to Twenty(Sample data). #7424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request modifies the 'createdByName' field for the Airbnb company in the sample data, changing it from 'System' to 'Twenty (Sample data)' to provide more clarity about the data's origin.
- Updated 'createdByName' for Airbnb in
/packages/twenty-server/src/engine/workspace-manager/standard-objects-prefill-data/company.ts - Inconsistent application: change not applied to other sample company entries
- Potential for confusion due to inconsistent 'createdByName' values across sample data
- Consider applying the change uniformly to all sample company entries for consistency
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| @@ -45,7 +45,7 @@ export const companyPrefillData = async ( | |||
| position: 1, | |||
| createdBySource: 'MANUAL', | |||
| createdByWorkspaceMemberId: null, | |||
| createdByName: 'System', | |||
| createdByName: 'Twenty (Sample data)', | |||
There was a problem hiding this comment.
style: Consider updating 'createdByName' for other companies (lines 64, 80, 96, 112) to maintain consistency
FelixMalfait
approved these changes
Oct 4, 2024
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
I changed the createdByName from' system' to 'Twenty(Sample Data)'. --------- Co-authored-by: Félix Malfait <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the createdByName from' system' to 'Twenty(Sample Data)'.