Refactor graphql query runner and add mutation resolvers #7418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request implements significant refactoring and enhancements to the GraphQL query runner and mutation resolvers in the Twenty server.
- Introduced new resolver services for create, update, delete, and destroy operations, improving modularity and maintainability
- Implemented a GraphqlQueryResolverFactory to centralize resolver creation and simplify adding new resolvers
- Added ApiEventEmitterService to handle event emission for various database operations
- Refactored existing resolvers to use dependency injection and implement a common ResolverService interface
- Updated WorkspaceQueryRunnerOptions to include objectMetadataMap, potentially improving performance by reducing metadata computations
30 file(s) reviewed, 11 comment(s)
Edit PR Review Bot Settings
...rver/src/engine/api/graphql/graphql-query-runner/factories/graphql-query-resolver.factory.ts
Outdated
Show resolved
Hide resolved
...es/twenty-server/src/engine/api/graphql/graphql-query-runner/graphql-query-runner.service.ts
Show resolved
Hide resolved
...erver/src/engine/api/graphql/graphql-query-runner/helpers/process-nested-relations.helper.ts
Outdated
Show resolved
Hide resolved
...ine/api/graphql/graphql-query-runner/resolvers/graphql-query-destroy-one-resolver.service.ts
Show resolved
Hide resolved
...api/graphql/graphql-query-runner/resolvers/graphql-query-find-duplicates-resolver.service.ts
Outdated
Show resolved
Hide resolved
...ine/api/graphql/graphql-query-runner/resolvers/graphql-query-update-many-resolver.service.ts
Outdated
Show resolved
Hide resolved
...gine/api/graphql/graphql-query-runner/resolvers/graphql-query-update-one-resolver.service.ts
Outdated
Show resolved
Hide resolved
...nty-server/src/engine/api/graphql/graphql-query-runner/services/api-event-emitter.service.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+124
to
+126
| if (value && typeof value === 'object' && value['edges']) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
style: This check might miss other nested objects without 'edges'. Consider a more robust approach for identifying and handling nested structures.
.../src/engine/api/graphql/workspace-resolver-builder/factories/delete-many-resolver.factory.ts
Show resolved
Hide resolved
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Fixes twentyhq#6859 This PR adds all the remaining resolvers for - updateOne/updateMany - createOne/createMany - deleteOne/deleteMany - destroyOne - restoreMany Also - refactored the graphql-query-runner to be able to add other resolvers without too much boilerplate. - add missing events that were not sent anymore as well as webhooks - make resolver injectable so they can inject other services as well - use objectMetadataMap from cache instead of computing it multiple time - various fixes (mutation not correctly parsing JSON, relationHelper fetching data with empty ids set, ...) Next steps: - Wrapping query builder to handle DB events properly - Move webhook emitters to db event listener - Add pagination where it's missing (findDuplicates, nested relations, etc...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6859
This PR adds all the remaining resolvers for
Also
Next steps: