-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat : Toggle Eye Icon to Expand/Collapse Kanban Card #7396
Feat : Toggle Eye Icon to Expand/Collapse Kanban Card #7396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request implements a toggle functionality for the eye icon in Kanban cards, allowing users to expand and collapse card details in compact mode.
- Updated
RecordBoardCard.tsx
to toggleisCardInCompactMode
state when clicking the eye icon - Removed
onMouseLeaveBoard
function andonMouseLeave
event fromStyledBoardCard
component - Eye icon now remains visible and clickable after expanding the card
- Addresses issue Toggle Eye Icon to Expand/Collapse Kanban Card #7389 by enabling users to collapse expanded cards in compact mode
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
...ront/src/modules/object-record/record-board/record-board-card/components/RecordBoardCard.tsx
Outdated
Show resolved
Hide resolved
...ront/src/modules/object-record/record-board/record-board-card/components/RecordBoardCard.tsx
Outdated
Show resolved
Hide resolved
...ront/src/modules/object-record/record-board/record-board-card/components/RecordBoardCard.tsx
Outdated
Show resolved
Hide resolved
...ront/src/modules/object-record/record-board/record-board-card/components/RecordBoardCard.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments! ;)
@Bonapara 2024-10-04.22-58-21.mp4 |
@FelixMalfait |
Great points @ehconitin agree with both! Thank you Thanks @Vardhaman619! |
Awarding Vardhaman619: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/Vardhaman619 |
Log
|
This pull request implements the functionality to toggle the eye icon in Kanban cards to expand or collapse the card details. twentyhq#7389 [toogle-button-in-kanban-card.webm](https://github.com/user-attachments/assets/3bc1a31c-4053-429a-95e7-aa98188c39e4) --------- Co-authored-by: Nitin Koche <[email protected]> Co-authored-by: Félix Malfait <[email protected]>
This pull request implements the functionality to toggle the eye icon in Kanban cards to expand or collapse the card details.
#7389
toogle-button-in-kanban-card.webm