fix: filter and sort options to match order of table columns #7392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request implements the desired behavior for filter and sort menu items to match the order of table columns, addressing issue #5960. Key changes include:
- Modified
ObjectFilterDropdownFilterSelect.tsxto separate visible and hidden columns - Implemented sorting of visible columns to match table column order
- Added a separator between visible and hidden column sections
- Updated filtering logic to handle visible and hidden columns separately
- Utilized
RecordIndexRootPropsContextanduseRecordTableStateshook for column information
The changes align the filter and sort dropdown menu items with the table column order, improving user experience and consistency across the interface.
1 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings
...modules/object-record/object-filter-dropdown/components/ObjectFilterDropdownFilterSelect.tsx
Show resolved
Hide resolved
...modules/object-record/object-filter-dropdown/components/ObjectFilterDropdownFilterSelect.tsx
Show resolved
Hide resolved
...modules/object-record/object-filter-dropdown/components/ObjectFilterDropdownFilterSelect.tsx
Outdated
Show resolved
Hide resolved
|
@CoreTeamTwenty Ready for Review |
|
@charlesBochet Used this PR to refactor the hierarchy of object filter dropdown and created the component state v2 wrapper and some component states. |
lucasbordeau
approved these changes
Oct 10, 2024
|
Awarding Nabhag8848: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/Nabhag8848 |
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
…q#7392) ### ISSUE - Closes twentyhq#5960 ### Demo https://github.com/user-attachments/assets/279b19cf-6841-4a63-82ed-423bc0eb4395 --------- Co-authored-by: Lucas Bordeau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE
Demo
Screen.Recording.2024-10-02.at.4.42.51.PM.mov