Vertically center Kanban card titles in compact mode #7391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses the issue of Kanban card titles not being vertically centered in compact mode (#7385). The main change is in the StyledBoardCardHeader component of RecordBoardCard.tsx.
- Increased padding-bottom for compact view from 0 to 2 units of spacing in
StyledBoardCardHeader - Improves vertical alignment of card titles in compact mode
- Enhances readability and aesthetics of the Kanban board
- Aims to achieve the desired 40px height for compact cards
- Addresses the visual discrepancy shown in the issue's screenshots
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
…er-card-titles-compact-mode
ehconitin
approved these changes
Oct 2, 2024
|
Awarding Vardhaman619: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/Vardhaman619 |
|
Thanks @Vardhaman619 for your contribution! |
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
This PR addresses the issue of[ Kanban card titles not being vertically centered in compact mode](twentyhq#7385). The following changes have been made: Updated CSS styles to ensure that titles are properly aligned vertically within their respective cards when in compact mode. Enhanced overall readability and aesthetics of the Kanban board. twentyhq#7385  Co-authored-by: Nitin Koche <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue of Kanban card titles not being vertically centered in compact mode. The following changes have been made:
Updated CSS styles to ensure that titles are properly aligned vertically within their respective cards when in compact mode.
Enhanced overall readability and aesthetics of the Kanban board.
#7385