Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6653 serverless functions store and use environment variables in serverless function scripts #7390

Merged
merged 33 commits into from
Oct 3, 2024
Merged

6653 serverless functions store and use environment variables in serverless function scripts #7390

merged 33 commits into from
Oct 3, 2024

Conversation

martmull
Copy link
Contributor

@martmull martmull commented Oct 2, 2024

image
image

@martmull martmull linked an issue Oct 2, 2024 that may be closed by this pull request
Serverless Functions: Store and use environment variables in serverless function scripts #6653
Closed
@martmull martmull marked this pull request as ready for review October 2, 2024 12:37
greptile-apps[bot]
greptile-apps bot reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request implements significant changes to support environment variables in serverless function scripts and enhances the overall serverless function management system.

  • Introduced multi-file support in SettingsServerlessFunctionCodeEditorTab.tsx and CodeEditor.tsx, allowing for separate environment files and improved code organization
  • Removed sourceCodeHash field from serverless function schema and related components, indicating a shift in tracking function changes
  • Added new download method to StorageDriver interface and implemented in LocalDriver and S3Driver, enhancing file management capabilities
  • Refactored LambdaDriver and LocalDriver to support environment variables, improve build processes, and enhance error handling
  • Replaced single file compilation with project-based compilation in compile-typescript.ts, enabling more complex TypeScript projects for serverless functions

29 file(s) reviewed, 15 comment(s)
Edit PR Review Bot Settings

packages/twenty-server/src/constants/assets-path.ts Show resolved Hide resolved
packages/twenty-server/src/engine/core-modules/file-storage/drivers/local.driver.ts Show resolved Hide resolved
packages/twenty-server/src/engine/core-modules/file-storage/drivers/local.driver.ts Outdated Show resolved Hide resolved
packages/twenty-server/src/engine/core-modules/file-storage/drivers/s3.driver.ts Outdated Show resolved Hide resolved
packages/twenty-server/src/engine/core-modules/file-storage/drivers/s3.driver.ts Outdated Show resolved Hide resolved
packages/twenty-server/src/engine/core-modules/serverless/drivers/constants/source-file-name.ts Outdated Show resolved Hide resolved
packages/twenty-server/src/engine/core-modules/serverless/drivers/local.driver.ts Show resolved Hide resolved
packages/twenty-server/src/engine/core-modules/serverless/drivers/local.driver.ts Show resolved Hide resolved
packages/twenty-server/src/engine/core-modules/serverless/drivers/local.driver.ts Outdated Show resolved Hide resolved
...server/src/engine/core-modules/serverless/drivers/utils/get-base-typescript-project-files.ts Outdated Show resolved Hide resolved
Devessier
Devessier reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@Devessier Devessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job, @martmull, as usual. The serverless functions feature is complex, but you can manage it perfectly. The scope of the feature goes from creating a smooth UX within a code editor to executing arbitrary code safely. Good job!

I wrote some comments about little things. Feel free to reach out to me if I wasn't clear enough.

...server/src/engine/core-modules/serverless/drivers/utils/get-base-typescript-project-files.ts Outdated Show resolved Hide resolved
...server/src/engine/core-modules/serverless/drivers/utils/get-base-typescript-project-files.ts Outdated Show resolved Hide resolved
...server/src/engine/core-modules/serverless/drivers/utils/get-base-typescript-project-files.ts Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
...es/settings/serverless-functions/components/tabs/SettingsServerlessFunctionCodeEditorTab.tsx Outdated Show resolved Hide resolved
packages/twenty-server/src/engine/core-modules/serverless/drivers/local.driver.ts Show resolved Hide resolved
packages/twenty-server/src/engine/core-modules/serverless/drivers/local.driver.ts Show resolved Hide resolved
packages/twenty-server/src/engine/core-modules/serverless/drivers/utils/compile-typescript.ts Show resolved Hide resolved
...twenty-server/src/engine/metadata-modules/serverless-function/serverless-function.service.ts Outdated Show resolved Hide resolved
...twenty-server/src/engine/metadata-modules/serverless-function/serverless-function.service.ts Outdated Show resolved Hide resolved
@Devessier Devessier self-requested a review October 3, 2024 10:08
Devessier
Devessier approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@Devessier Devessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 😄 🎉

...es/settings/serverless-functions/components/tabs/SettingsServerlessFunctionCodeEditorTab.tsx Show resolved Hide resolved
...es/twenty-front/src/pages/settings/serverless-functions/SettingsServerlessFunctionDetail.tsx Show resolved Hide resolved
packages/twenty-server/src/engine/core-modules/serverless/drivers/local.driver.ts Show resolved Hide resolved
packages/twenty-front/src/modules/ui/input/code-editor/components/CodeEditor.tsx Outdated
Comment on lines 131 to 140
const onEnvFileChange = (value: string) => {
if (
!isDefined(currentFile) ||
currentFile.path !== '.env' ||
!isDefined(monacoInstance)
) {
return;
}
setEnvFileLib(value);
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay 😮 👌

@martmull martmull force-pushed the 6653-serverless-functions-store-and-use-environment-variables-in-serverless-function-scripts branch from 4f30c4f to 2c1e431 Compare October 3, 2024 11:47
@martmull martmull merged commit 62fe1d0 into main Oct 3, 2024
7 of 13 checks passed
@martmull martmull deleted the 6653-serverless-functions-store-and-use-environment-variables-in-serverless-function-scripts branch October 3, 2024 11:56
harshit078 pushed a commit to harshit078/twenty that referenced this pull request Oct 14, 2024
@martmull @harshit078
6653 serverless functions store and use environment variables in serv…
ed6d46f 
…erless function scripts (twentyhq#7390)

![image](https://github.com/user-attachments/assets/a15bd4c1-3db4-4466-b748-06bdf3874354)

![image](https://github.com/user-attachments/assets/71242dfb-956b-43ed-9704-87cb0dfbc98d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@jcarrus jcarrus jcarrus left review comments

@Devessier Devessier Devessier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serverless Functions: Store and use environment variables in serverless function scripts
3 participants
@martmull @jcarrus @Devessier