fix: zero showing in record cell and page #7384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses the issue of zero values not being displayed correctly in the CurrencyDisplay component for currency fields.
- Modified
CurrencyDisplay.tsxto differentiate between null (empty) and zero values - Updated
amountToDisplaycalculation to handle zero values properly - Adjusted the condition for displaying formatted amounts to include zero values
- Ensures zero currency values are now visible in record cells and record pages
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
|
/award 200 |
|
Awarding nganphan123: 200 points 🕹️ Well done! Check out your new contribution on oss.gg/nganphan123 |
|
Thank you! |
|
Thanks @nganphan123 for your contribution! |
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
This PR fixes zero being displayed as empty in record cell and show page in currency field twentyhq#6802 I checked graphql resquests and the data is stored in the correct form (0 or null). The problem only lies in the front end and how the field is null checked. --------- Co-authored-by: Félix Malfait <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes zero being displayed as empty in record cell and show page in currency field #6802
I checked graphql resquests and the data is stored in the correct form (0 or null). The problem only lies in the front end and how the field is null checked.