-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Center Functions Empty state #7378
fix: Center Functions Empty state #7378
Conversation
Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request centers the empty state on the Functions page in the settings, addressing issue #7012. Key changes include:
- Modified
SettingsServerlessFunctionsTable
to renderSettingsPageContainer
only when serverless functions exist - Updated
SettingsServerlessFunctions
to directly renderSettingsServerlessFunctionsTable
within aSection
component - Aligned empty state behavior with other pages like '/rockets' for consistency
- Improved visual layout by centering the empty state when no functions are present
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awarding Utzig26: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/Utzig26 |
## Description - This PR fix twentyhq#7012 - It changes the logic behind the rendering of `SettingsPageContainer` component. Now, the component is only rendered when the page content is not blank. ## Changes | Before | After | |--------|--------| | ![image](https://github.com/user-attachments/assets/98b64370-f145-41a2-a829-f86ae9687f73) | ![image](https://github.com/user-attachments/assets/4cb0cc32-a669-4151-9444-4bc734bd2909) | <details><summary>Details</summary> <p> This change aligns the behavior of the settings page with the existing logic found on the `/rockets` page <img src="https://github.com/user-attachments/assets/d2b80fbc-83e4-4823-a708-6775e19a153a"/> </p> </details> Co-authored-by: Charles Bochet <[email protected]>
Description
SettingsPageContainer
component. Now, the component is only rendered when the page content is not blank.Changes
Details
This change aligns the behavior of the settings page with the existing logic found on the `/rockets` page