7336 create contextstore #7374
Merged
7336 create contextstore #7374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements a new ContextStore feature, introducing three new states to manage object metadata, views, and targeted records across the application.
- Added
contextStoreCurrentObjectMetadataIdState,contextStoreCurrentViewIdState, andcontextStoreTargetedRecordIdsStatein separate files underpackages/twenty-front/src/modules/context-store/states/ - Updated
PageChangeEffect.tsxto manage new context store states based on URL parameters - Modified
RecordIndexBoardDataLoaderEffect.tsxandRecordIndexTableContainerEffect.tsxto updatecontextStoreTargetedRecordIdsStatewith selected record IDs - Introduced
useSetViewInUrlhook inpackages/twenty-front/src/modules/views/hooks/useSetViewInUrl.tsfor managing view ID in URL - Added
RecordShowPageEffect.tsxto updatecontextStoreTargetedRecordIdsStatewhen viewing a single record
11 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| @@ -49,6 +58,29 @@ export const PageChangeEffect = () => { | |||
| activityObjectNameSingular: CoreObjectNameSingular.Task, | |||
| }); | |||
|
|
|||
| const [searchParams] = useSearchParams(); | |||
There was a problem hiding this comment.
extract this to another ComponentEffect: ContextStorePageChangeEffect.tsx
| const [searchParams] = useSearchParams(); | ||
| const { objectNameSingular, objectNamePlural } = useParams(); | ||
|
|
||
| const objectMetadataItem = useRecoilValue( |
| const [searchParams] = useSearchParams(); | ||
| const { objectNameSingular, objectNamePlural } = useParams(); | ||
|
|
||
| const objectMetadataItem = useRecoilValue( |
There was a problem hiding this comment.
introduce a hook for that useObjectMetadataItemFromPluralOrSingular
| @@ -37,6 +38,7 @@ export const QueryParamsViewIdEffect = () => { | |||
| objectMetadataItemId?.id, | |||
| lastVisitedObjectMetadataItemId, | |||
| ); | |||
| const { setViewInUrl } = useSetViewInUrl(); | |||
There was a problem hiding this comment.
we should push the viewId from there
packages/twenty-front/src/modules/app/effect-components/PageChangeEffect.tsx
Outdated
Show resolved
Hide resolved
| import { useParams } from 'react-router-dom'; | ||
| import { useSetRecoilState } from 'recoil'; | ||
|
|
||
| export const RecordShowPageEffect = ({ recordId }: { recordId: string }) => { |
There was a problem hiding this comment.
RecordShowPageContextStoreEffect
charlesBochet
approved these changes
Oct 8, 2024
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Closes twentyhq#7336 Create 3 states: - `contextStoreCurrentObjectMetadataIdState`: is set when we change object metadata - `contextStoreCurrentViewIdState`: is set when we change view - `contextStoreTargetedRecordIdsState`: is set when we select records inside a table or a board or when a show page is opened. Is reset when we change view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7336
Create 3 states:
contextStoreCurrentObjectMetadataIdState: is set when we change object metadatacontextStoreCurrentViewIdState: is set when we change viewcontextStoreTargetedRecordIdsState: is set when we select records inside a table or a board or when a show page is opened. Is reset when we change view.