-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: enhance REST API OpenAPI spec with nested filter example #7366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request enhances the REST API OpenAPI specification by adding documentation and examples for filtering on nested object properties.
- Added description for filtering nested objects in
computeFilterParameters
function inpackages/twenty-server/src/engine/core-modules/open-api/utils/parameters.utils.ts
- Included new example
simpleNested
for filtering on nested properties inparameters.utils.ts
- Updated corresponding test file
packages/twenty-server/src/engine/core-modules/open-api/utils/__tests__/parameters.utils.spec.ts
to include tests for new nested filter examples - Improves developer experience by providing clearer documentation on using nested filters in API queries
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Thanks, great to improve the doc! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm thank you
Thanks @LucasZapico for your contribution! |
Hey I just want to bump this a bit. I saw your response @FelixMalfait and I wanted to do some further exploration on my end. I want to do some discovery on the viability of setting up playwright api tests tied into the openAPi tool you all are using to create spec, test, parity in a "clean" way. This way the docs, and api are exactly what is expected. We'll see where it goes. Cheers No promises but I just wanted to let you know I haven't forgotten. |
Great thanks @LucasZapico! I know we have been working on end-to-end tests for the server but I didn't follow this at all #6923 / #6717 ; cc @charlesBochet Also as mentioned above I think it's misleading to talk about nested object when we can't filter by nested object @martmull |
@FelixMalfait I merged, then I saw your comment. Indeed, we should improve the wording |
Associated issue: Enhance REST API documentation for querying on nested objects [#7365]
Context
Description: The current OpenAPI spec does not call out the preferred method for filtering by nested object properties.
Proposed Change:
Add abstract for to filter on nested object properties
Add example for filter on nested object properties