increase export feature page size #7341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR increases the export feature page size from 30 to 200 records per request, aiming to improve export performance for the Twenty application.
- Introduced new constant
EXPORT_TABLE_DATA_DEFAULT_PAGE_SIZEset to 200 in/packages/twenty-front/src/modules/object-record/record-index/options/constants/ExportTableDataDefaultPageSize.ts - Updated
useExportTableDataanduseTableDatahooks to use the new constant for default page size - Potential improvement in export efficiency by reducing the number of API calls for large exports
- Consider monitoring server load and client-side memory usage with this increased page size
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Weiko
added a commit
that referenced
this pull request
Sep 30, 2024
## Context Now that we have improved performances, we can increase the export feature page size from 30 to 200 (and probably above if results are good). This should be ok since we are only querying the first level of an object and omit relations. I've moved this value to a constant.
Weiko
added a commit
that referenced
this pull request
Sep 30, 2024
## Context Now that we have improved performances, we can increase the export feature page size from 30 to 200 (and probably above if results are good). This should be ok since we are only querying the first level of an object and omit relations. I've moved this value to a constant.
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
## Context Now that we have improved performances, we can increase the export feature page size from 30 to 200 (and probably above if results are good). This should be ok since we are only querying the first level of an object and omit relations. I've moved this value to a constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Now that we have improved performances, we can increase the export feature page size from 30 to 200 (and probably above if results are good). This should be ok since we are only querying the first level of an object and omit relations.
I've moved this value to a constant.