minor fix - fixed forwardRef and unique key console errors #7337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses two console errors in the React components, improving code quality and adherence to best practices without altering core functionality.
- Moved 'key' prop from ObjectFilterDropdownFilterSelectMenuItem to parent SelectableItem in
packages/twenty-front/src/modules/object-record/object-filter-dropdown/components/ObjectFilterDropdownFilterSelect.tsxfor better list rendering - Enhanced DropdownMenuSearchInput in
packages/twenty-front/src/modules/ui/layout/dropdown/components/DropdownMenuSearchInput.tsxto correctly handle forwarded refs, resolving forwardRef usage error - Both changes address specific console errors mentioned in issue fix(front): fix some console errors #7183, improving overall code quality
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
thomtrp
approved these changes
Oct 1, 2024
|
Thanks @ehconitin for your contribution! |
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context - #7183