Fix cursor should not be pointer when record image identifier is not Editable #7320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sachinks07
commented
Sep 29, 2024
sachinks07
commented
- This PR solves the issue Cursor should not be "pointer" when record image identifier is not editable Cursor should not be "pointer" when record image identifier is not editable #7277
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses issue #7277 by modifying the cursor behavior for non-editable record image identifiers.
- Added
isAvatarEditableprop toShowPageSummaryCardinRecordShowContainer.tsx, set to true only for 'person' objects - Implemented conditional cursor styling in
ShowPageSummaryCard.tsxbased onisAvatarEditableprop - Cursor now defaults to 'default' instead of 'pointer' for non-editable avatars, improving UI consistency
- Changes affect only the avatar/image area, not impacting other editable fields
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
martmull
requested changes
Sep 30, 2024
packages/twenty-front/src/modules/object-record/record-show/components/RecordShowContainer.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageSummaryCard.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageSummaryCard.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageSummaryCard.tsx
Outdated
Show resolved
Hide resolved
…in showsummaryCard
|
@martmull Thanks for the suggestion. Have made the changes with respect to the suggestions. |
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
…Editable (twentyhq#7320) - This PR solves the issue Cursor should not be "pointer" when record image identifier is not editable twentyhq#7277 --------- Co-authored-by: Sachin KS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.