-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix icon resizing issue for Notes and Tasks #7318
Fix icon resizing issue for Notes and Tasks #7318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request addresses an icon resizing issue in the Chip component, specifically for Notes and Tasks icons, ensuring consistent size regardless of content or column width.
- Added CSS rule
flex-shrink: 0;
to SVG icons inStyledContainer
in/packages/twenty-ui/src/display/chip/components/Chip.tsx
- Prevents icon shrinking when chip content is long or column width is reduced
- Improves UI consistency for Notes and Tasks icons as described in issue
Notes
andTasks
icons size issue #7282 - Enhances user experience by maintaining stable icon sizes across different scenarios
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This pull request addresses a [resizing issue with the Notes and Tasks icons](twentyhq#7282). Previously, the icons would change size based on the length of the title or when the column width was adjusted, leading to inconsistent UI behavior. This update ensures that the icons maintain a stable size, enhancing the overall user experience. Solves Issue : twentyhq#7282 [twenty-icon-sizing-issue.webm](https://github.com/user-attachments/assets/3ef59592-4dfb-463e-bc7b-a803ee105211)
This pull request addresses a resizing issue with the Notes and Tasks icons. Previously, the icons would change size based on the length of the title or when the column width was adjusted, leading to inconsistent UI behavior. This update ensures that the icons maintain a stable size, enhancing the overall user experience.
Solves Issue : #7282
twenty-icon-sizing-issue.webm