Support Emails and Phones in Spreadsheet import #7312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances spreadsheet import functionality by adding support for EMAILS and PHONES field types, while also removing deprecated phone search from the command menu.
- Added support for EMAILS and PHONES in
CompositeFieldImportLabels.tsanduseBuildAvailableFieldsForImport.ts - Updated
buildRecordFromImportedStructuredRow.tsto process email and phone data during import - Removed 'phone' filter from people search in
CommandMenu.tsx - Added TODO in
sanitizeRecordInput.tsfor implementing field value validation - Identified potential for code refactoring in spreadsheet import functionality to reduce complexity and duplication
5 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| @@ -155,6 +156,42 @@ export const useBuildAvailableFieldsForImport = () => { | |||
| fieldMetadataItem.label, | |||
| ), | |||
| }); | |||
| } else if (fieldMetadataItem.type === FieldMetadataType.Emails) { | |||
There was a problem hiding this comment.
style: Consider extracting this repeated logic into a separate function to reduce duplication
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
This is a fast follow on v0.30 release: - removing phone (deprecated PHONE field type) search from command menu. I could have replaced it by a phone (PHONES field type) search but as we are about to release the new search in v0.31 it does not seem to worse the investment - supporting EMAILS and PHONES field types in spreadsheet import Note: while working on Spreadsheet import I found the code quite complex and with areas having duplicated code. It does not seem to be a high priority as I was able to maintain it at a low cost but it's not a peaceful code surface to navigate!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fast follow on v0.30 release:
Note: while working on Spreadsheet import I found the code quite complex and with areas having duplicated code. It does not seem to be a high priority as I was able to maintain it at a low cost but it's not a peaceful code surface to navigate!