fix: Title overflows in mobile viewport for right drawer #7311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses the issue of title overflow in the mobile viewport for the right drawer component. The change improves the user experience on mobile devices by preventing horizontal scrolling caused by long titles.
- Added
overflow-x: hiddentoStyledInfoContainerfor mobile viewports - Imported
MOBILE_VIEWPORTconstant from 'twenty-ui' for consistent breakpoint usage - Applied the fix specifically to the
ShowPageSummaryCardcomponent, which is used in the right drawer - The change affects the layout of notes and tasks where the
rightDrawercomponent is used
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageSummaryCard.tsx
Outdated
Show resolved
Hide resolved
martmull
requested changes
Sep 30, 2024
packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageSummaryCard.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageSummaryCard.tsx
Outdated
Show resolved
Hide resolved
martmull
approved these changes
Sep 30, 2024
|
Thanks @harshit078 for your contribution! |
harshit078
added a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
## Description - This PR solves the issue twentyhq#7310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description