Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: Default Demo Login Credentials to [email protected] #7308

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

vijaysingh2219
Copy link
Contributor

@vijaysingh2219 vijaysingh2219 commented Sep 28, 2024

This PR updates the default login credentials for the demo environment. The current default is set to [email protected], and we want to change it to:

Email: [email protected]
Password: Applecar2025

Changes:

Resolves #7304

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request updates the default demo login credentials in the useSignInUpForm hook, changing the email from '[email protected]' to '[email protected]' while maintaining the existing password.

  • Modified packages/twenty-front/src/modules/auth/sign-in-up/hooks/useSignInUpForm.ts to update the prefilled email address
  • Aligned the default demo account with the specifications in issue Set default demo account to [email protected] #7304
  • Kept the password unchanged as 'Applecar2025'
  • Ensures consistency between the demo environment and the desired behavior

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@vijaysingh2219
Copy link
Contributor Author

@Bonapara Please review when you get a chance.

Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contribution. We still want to keep [email protected] here though. This is because Demo is not automatically seeded so this account will be missing and login won't work in the current state, I don't think this is the correct way to do this.
We could use an env variable for that such as SIGN_IN_PREFILLED_DEFAULT_LOGIN. You can check how it's done with SIGN_IN_PREFILLED.
(cc @charlesBochet)

@vijaysingh2219
Copy link
Contributor Author

Thanks for your input, @Weiko! I've now adjusted the code to ensure [email protected] is used as the default login, as you suggested. The environment variable SIGN_IN_PREFILLED_DEFAULT_LOGIN is also included for flexibility, but it defaults to [email protected] if not provided. Similarly, the password is prefilled with Applecar2025 or SIGN_IN_PREFILLED_DEFAULT_PASSWORD when available.

@FelixMalfait
Copy link
Member

Hey I'm sorry the issue wasn't clear. We actually transitioned to [email protected] to be prefilled for demo but I hadn't updated the README yet because the server hadn't been deployed yet. Thanks a lot for the attempt!

@FelixMalfait FelixMalfait merged commit a8c07bf into twentyhq:main Oct 2, 2024
3 checks passed
harshit078 pushed a commit to harshit078/twenty that referenced this pull request Oct 14, 2024
This PR updates the default login credentials for the demo environment.
The current default is set to [email protected], and we want to change it
to:

Email: `[email protected]`
Password: `Applecar2025`

Changes:

- Updated default demo login email from [email protected] to [email protected]

Resolves twentyhq#7304

---------

Co-authored-by: Félix Malfait <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set default demo account to [email protected]
3 participants