-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tab design improvements #7307
Tab design improvements #7307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request improves the minimized tab design in the right drawer, addressing the requirements specified in issue #7150.
- Updated
StyledContainer
inRightDrawer.tsx
with new styling, including border-radius, blur effect, and box shadow - Modified
animationVariants.minimized
to adjust width and height of the minimized tab - Removed border-left and border-top styles from
StyledContainer
for a cleaner look - Added
backdrop-filter: blur(40px)
to create the desired blur effect on the minimized tab - Potential performance impact due to the blur effect should be considered, especially on lower-end devices
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
packages/twenty-front/src/modules/ui/layout/right-drawer/components/RightDrawer.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/right-drawer/components/RightDrawer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments ;)
packages/twenty-front/src/modules/ui/layout/right-drawer/components/RightDrawer.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/right-drawer/components/RightDrawer.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/right-drawer/components/RightDrawer.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/right-drawer/components/RightDrawer.tsx
Outdated
Show resolved
Hide resolved
@FelixMalfait LGTM! Update - lets wait on the merge, need some clarifications |
@Bonapara |
We should most likely keep the current behavior on mobile, I don't think there's room to display both the tab bar and additional sub-tabs :) But this PR needs to be adjusted because it changes the design not just of the minimized side-panel but also of the standard right drawer. In that case, we want to keep the previous look. Animations looked fine to me! |
Hi @FelixMalfait, I can keep the right tab bar design & change the minimize tab design. |
@ArafatOSDev thanks! Would be great if you can make the required adjustments |
@ArafatOSDev are you still working on this PR? |
@ehconitin Yes, I am working on this PR. |
d72a8db
to
0e9aa15
Compare
@ehconitin Can you check this PR now? |
Hey @ArafatOSDev I pushed a fix. We should avoid introducing new variables + avoid using useEffect unless it's strictly necessary. Also the border color was stronger in minimized state. I revert the commits to start fresh but took inspiration from your code. Thanks for your contribution! |
/award 100 |
Awarding ArafatOSDev: 100 points 🕹️ Well done! Check out your new contribution on oss.gg/ArafatOSDev |
Thanks @FelixMalfait |
Thanks @FelixMalfait I will follow your suggestion for the next contribution. |
## What does this PR do? Improve minimize tab design. Fixes twentyhq#7150 <img width="329" alt="Screenshot 2024-09-28 at 11 46 35 AM" src="https://github.com/user-attachments/assets/84eb058f-845f-4866-8428-ed0c1df619a8"> --------- Co-authored-by: Félix Malfait <[email protected]>
What does this PR do?
Improve minimize tab design.
Fixes #7150