Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab design improvements #7307

Merged
merged 6 commits into from
Oct 5, 2024

Conversation

ArafatOSDev
Copy link
Contributor

What does this PR do?

Improve minimize tab design.

Fixes #7150

Screenshot 2024-09-28 at 11 46 35 AM

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request improves the minimized tab design in the right drawer, addressing the requirements specified in issue #7150.

  • Updated StyledContainer in RightDrawer.tsx with new styling, including border-radius, blur effect, and box shadow
  • Modified animationVariants.minimized to adjust width and height of the minimized tab
  • Removed border-left and border-top styles from StyledContainer for a cleaner look
  • Added backdrop-filter: blur(40px) to create the desired blur effect on the minimized tab
  • Potential performance impact due to the blur effect should be considered, especially on lower-end devices

2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings

Copy link
Contributor

@ehconitin ehconitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments ;)

@ehconitin
Copy link
Contributor

ehconitin commented Sep 28, 2024

@FelixMalfait LGTM!
Could you check if animations are smooth, I couldnt judge with my laggy machine :)

Update - lets wait on the merge, need some clarifications

@ehconitin
Copy link
Contributor

@Bonapara
should minimized tab also appear for mobile devices?
As of now we dont show minimize button for mobile devices.

@FelixMalfait
Copy link
Member

We should most likely keep the current behavior on mobile, I don't think there's room to display both the tab bar and additional sub-tabs :)

But this PR needs to be adjusted because it changes the design not just of the minimized side-panel but also of the standard right drawer. In that case, we want to keep the previous look.

Animations looked fine to me!

@ArafatOSDev
Copy link
Contributor Author

Hi @FelixMalfait, I can keep the right tab bar design & change the minimize tab design.

@FelixMalfait
Copy link
Member

@ArafatOSDev thanks! Would be great if you can make the required adjustments

@ehconitin
Copy link
Contributor

@ArafatOSDev are you still working on this PR?

@ArafatOSDev
Copy link
Contributor Author

@ehconitin Yes, I am working on this PR.

@ArafatOSDev ArafatOSDev force-pushed the tab-design-improvement branch from d72a8db to 0e9aa15 Compare October 4, 2024 10:49
@ArafatOSDev
Copy link
Contributor Author

@ehconitin Can you check this PR now?

@FelixMalfait
Copy link
Member

Hey @ArafatOSDev I pushed a fix. We should avoid introducing new variables + avoid using useEffect unless it's strictly necessary. Also the border color was stronger in minimized state. I revert the commits to start fresh but took inspiration from your code. Thanks for your contribution!

@FelixMalfait
Copy link
Member

/award 100

Copy link

oss-gg bot commented Oct 5, 2024

Awarding ArafatOSDev: 100 points 🕹️ Well done! Check out your new contribution on oss.gg/ArafatOSDev

@FelixMalfait FelixMalfait enabled auto-merge (squash) October 5, 2024 09:38
@FelixMalfait FelixMalfait merged commit 4d67787 into twentyhq:main Oct 5, 2024
8 checks passed
@ehconitin
Copy link
Contributor

Thanks @FelixMalfait

@ArafatOSDev
Copy link
Contributor Author

Thanks @FelixMalfait I will follow your suggestion for the next contribution.

harshit078 pushed a commit to harshit078/twenty that referenced this pull request Oct 14, 2024
## What does this PR do?
Improve minimize tab design. 

Fixes twentyhq#7150 

<img width="329" alt="Screenshot 2024-09-28 at 11 46 35 AM"
src="https://github.com/user-attachments/assets/84eb058f-845f-4866-8428-ed0c1df619a8">

---------

Co-authored-by: Félix Malfait <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab design improvements
3 participants