Fix viewFilter operand for dateTime fields #7306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weiko
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request introduces a new command to fix view filter operands for date-time fields, updating 'lessThan' to 'before' and 'moreThan' to 'after' across all active workspaces.
- Added
FixViewFilterOperandForDateTimeCommandinpackages/twenty-server/src/database/commands/upgrade-version/0-30/0-30-fix-view-filter-operand-for-date-time.command.ts - Included
FixViewFilterOperandForDateTimeCommandinUpgradeTo0_30Commandconstructor but not executed inexecuteActiveWorkspacesCommand - Added
FixViewFilterOperandForDateTimeCommandtoUpgradeTo0_30CommandModuleproviders - Consider executing
fixViewFilterOperandForDateTimeCommandinexecuteActiveWorkspacesCommandto apply the fix during upgrades
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
Comment on lines
+43
to
+46
| const dataSourceMetadata = | ||
| await this.dataSourceService.getLastDataSourceMetadataFromWorkspaceId( | ||
| workspaceId, | ||
| ); |
There was a problem hiding this comment.
style: dataSourceMetadata is fetched but not used. Consider removing if unnecessary.
| @@ -28,6 +29,7 @@ export class UpgradeTo0_30Command extends ActiveWorkspacesCommandRunner { | |||
| private readonly setStaleMessageSyncBackToPendingCommand: SetStaleMessageSyncBackToPendingCommand, | |||
| private readonly fixEmailFieldsToEmailsCommand: FixEmailFieldsToEmailsCommand, | |||
| private readonly migratePhoneFieldsToPhones: MigratePhoneFieldsToPhonesCommand, | |||
| private readonly fixViewFilterOperandForDateTimeCommand: FixViewFilterOperandForDateTimeCommand, | |||
There was a problem hiding this comment.
logic: New command injected but not used in executeActiveWorkspacesCommand
charlesBochet
deleted the
c--fix-view-filter-operand-for-date-time-command
branch
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.