Fix email migration #7298
Merged
Fix email migration #7298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request enhances the email migration process by adding a check for the existence of the person email field before migration, improving robustness and error handling.
- Added conditional check in
migratePersonEmailFieldToEmailsFieldto skip migration if person email field is not found - Improved error logging in
packages/twenty-server/src/database/commands/upgrade-version/0-30/0-30-migrate-email-fields-to-emails.command.ts - Ensures compatibility with potential variations in person object metadata across different workspace configurations
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| workspaceQueryRunner, | ||
| dataSourceMetadata, | ||
| }); | ||
|
|
||
| if (personEmailFieldMetadata) { |
There was a problem hiding this comment.
style: Consider removing this condition as it's redundant after the previous check
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Checks if person standard email field exists before running the migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks if person standard email field exists before running the migration.