Fix use object metadata item #7297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request simplifies object metadata handling, particularly during workspace creation, by removing unnecessary checks and providers.
- Removed loading state dependency in
ObjectMetadataItemsLoadEffect, potentially leading to more frequent updates - Simplified
useObjectMetadataItemhook by removing inactive workspace handling and mock data logic - Removed
ObjectMetadataItemsProviderfromPageDecorator, streamlining the component structure - These changes may affect application behavior during workspace creation or when dealing with inactive workspaces
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
| objectMetadataItemFamilySelector({ | ||
| objectName: objectNameSingular, | ||
| objectNameType: 'singular', | ||
| }), | ||
| ); | ||
|
|
||
| let objectMetadataItems = useRecoilValue(objectMetadataItemsState); | ||
|
|
||
| if (currentWorkspace?.activationStatus !== WorkspaceActivationStatus.Active) { |
There was a problem hiding this comment.
doesn't this break the skeleton?
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Fixes a bug which happened during workspace creation and remove duplicated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug which happened during workspace creation and remove duplicated code