Fix standardId issues with phones field migration #7294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses standardId issues with the phones field migration, focusing on aligning the 'phones' field ID with the standard format used across the application.
- Updated 'phones' field standardId in
PERSON_STANDARD_FIELD_IDSto '20202020-3c51-43fa-8b6e-af39e29368ab' - Enhanced migration command in
0-30-migrate-phone-fields-to-phones.command.tsto handle standard and custom phone fields - Implemented data copying from deprecated phone fields to new phones fields
- Added error handling and rollback mechanisms for the migration process
- Updated view handling to reflect changes in phone field types
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
172
to
175
| await this.metadataDataSource.query( | ||
| `UPDATE "metadata"."fieldMetadata" SET "standardId" = $1 where "id"=$2`, | ||
| [PERSON_STANDARD_FIELD_IDS.phones, standardPersonPhoneField.id], | ||
| ); |
There was a problem hiding this comment.
logic: standardPersonPhoneField.id is used instead of standardPersonPhonesField.id
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Co-authored-by: Weiko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.