fix: Relation picker UX improvements #7292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses UX improvements for the relation picker component, focusing on the MultiRecordSelect component.
- Added StyledDropdownMenuSeparator in
MultiRecordSelect.tsxto ensure full-width separator - Introduced StyledCreateNewButton with 4px top margin for better spacing
- Separator now always renders, improving visual consistency
- Adjusted styling to align with design requirements from issue Relation picker UX improvements #7287
- Minor change in behavior: separator is now present regardless of selected items
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
|
Hi @harshit078 looks there is a "double gap" there is an 2px gap on top of the 4px margin you added |
lucasbordeau
approved these changes
Oct 9, 2024
|
Thanks @harshit078 for your contribution! |
harshit078
added a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Closes twentyhq#7287 > [!Note] > This PR solves the issue twentyhq#7287 > Updated margins between button and seperator and gave seperator full width --------- Co-authored-by: Lucas Bordeau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7287
Note
This PR solves the issue #7287
Updated margins between button and seperator and gave seperator full width