fix: Cursor pointer on Settings cards #7291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds a cursor pointer to the SettingsCard component in the settings page, addressing issue #7289 to improve user experience by indicating clickable cards.
- Modified
packages/twenty-front/src/modules/settings/components/SettingsCard.tsxto add hover effect and cursor pointer - Potential conflict with existing cursor styles in the StyledCard component
- Implementation focuses on CSS changes, not addressing HTML tag modifications for improved accessibility
- Consider reviewing usage in SettingsNavigationCard and SettingsAccountsSettingsSection for comprehensive solution
- May need additional changes to fully align with accessibility best practices mentioned in the issue
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| @@ -27,6 +27,7 @@ const StyledCard = styled(Card)<{ | |||
| width: 100%; | |||
| & :hover { | |||
| background-color: ${({ theme }) => theme.background.quaternary}; | |||
| cursor: pointer; | |||
There was a problem hiding this comment.
style: This overrides the existing cursor logic. Consider merging with the existing cursor style or removing the duplicate styling.
|
Thanks @harshit078 for your contribution! |
harshit078
added a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
> [!Note] > This PR solves the issue twentyhq#7289
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR solves the issue #7289