Enhance date and time format settings to reflect system preferences #7274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request enhances date and time format settings to reflect system preferences, improving user experience in the profile appearance settings.
- Added
detectSystemDateFormatfunction inDateTimeSettingsDateFormatSelect.tsxto display system's date format - Implemented
is12HourFormatfunction inDateTimeSettingsTimeFormatSelect.tsxto show current time in system format - Introduced
getSystemTimeZoneOptioninDateTimeSettingsTimeZoneSelect.tsxto detect and display system time zone - Updated Select components in all three files to show more informative system setting options
- Improved value handling in
DateTimeSettingsTimeZoneSelect.tsxfor direct passing to Select component
3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings
...-front/src/pages/settings/profile/appearance/components/DateTimeSettingsDateFormatSelect.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
20
to
23
| const is12HourFormat = (timeZone: string): boolean => { | ||
| const formattedTime = formatInTimeZone(new Date(), timeZone, 'hh:mm a'); | ||
| return formattedTime.includes('AM') || formattedTime.includes('PM'); | ||
| }; |
There was a problem hiding this comment.
style: Consider caching the result of is12HourFormat to avoid unnecessary calculations on each render
Comment on lines
33
to
34
| label: `System settings - ${systemTimeZoneOption?.label}`, | ||
| value: 'system', |
There was a problem hiding this comment.
logic: Handle potential undefined systemTimeZoneOption
|
Hi! I was just working on this issue: #6880 I made the page reflect the wanted format: Sorry, this is my first time contributing to an open source and I wasn't sure how to submit this with the pull request. It worked well locally though! |
lucasbordeau
approved these changes
Oct 9, 2024
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
…wentyhq#7274) Closes twentyhq#6880 --------- Co-authored-by: Lucas Bordeau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6880