Change tinybird event format #7272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the analytics event format in the Twenty server, separating pageview analytics from core events and simplifying the AnalyticsResolver.
- Updated
AnalyticsServiceinpackages/twenty-server/src/engine/core-modules/analytics/analytics.service.tsto use different datasources for pageview and other events - Simplified
AnalyticsResolverinpackages/twenty-server/src/engine/core-modules/analytics/analytics.resolver.tsby removing unused imports and parameters - Introduced a switch statement in
AnalyticsServiceto handle different event types, particularly distinguishing pageview events - Fixed a bug in the analytics enablement check within the
AnalyticsService
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
+65
to
+68
| const datasource = | ||
| createEventInput.action === 'pageview' | ||
| ? 'pageview' | ||
| : this.defaultDatasource; |
There was a problem hiding this comment.
style: This logic duplicates the check from the switch statement. Consider refactoring to avoid repetition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate pageview analytics from core events