Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analytics #7271

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fix analytics #7271

merged 1 commit into from
Sep 26, 2024

Conversation

FelixMalfait
Copy link
Member

Incorrect check

@FelixMalfait FelixMalfait merged commit a10324c into main Sep 26, 2024
3 of 4 checks passed
@FelixMalfait FelixMalfait deleted the fix-analytics-2 branch September 26, 2024 14:42
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses issues in the analytics functionality, focusing on simplifying the resolver and correcting the service logic for enabling analytics.

  • Removed unused imports and simplified track method signature in analytics.resolver.ts
  • Inverted condition in analytics.service.ts to correctly check if analytics is disabled
  • Potential impact on data collection if ANALYTICS_ENABLED environment variable is not properly set
  • Removed request parameter from track method, which may affect future functionality if it was intended for use
  • Consider thorough testing to ensure analytics tracking works as expected after these changes

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant