5922 - UI Overlap and State Persistence in Filter Menus #7270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses UI overlap and state persistence issues in filter menus, focusing on improving the user experience and layout. Key changes include:
- Implemented a new layout for the operand select menu, positioning it above and to the side of the filter menu for better visibility
- Added state reset functionality when closing dropdowns to prevent unwanted persistence of sub-filter/filter type menus
- Removed double borders between sub-filter/filter type menus for a cleaner appearance
- Simplified the ObjectFilterDropdownOperandButton component to always render the DropdownMenuHeader
- Introduced a handleDropdownClose callback in EditableFilterDropdownButton to reset UI state on closure
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
|
Thanks @ehconitin for your contribution! |
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5922
2024-09-26.19-05-16.mp4