Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phone fields migration command to 0 30 #7269

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

bosiraphael
Copy link
Contributor

Add phone fields migration command to 0 30

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request adds a new migration command for phone fields in version 0.30, moving it from the previously planned 0.32 upgrade. The main changes include:

  • Added MigratePhoneFieldsToPhonesCommand to migrate phone fields from PHONE type to PHONES type
  • Implemented migration logic for both standard person phone fields and custom phone fields in 0-30-migrate-phone-fields-to-phones.command.ts
  • Updated UpgradeTo0_30Command and UpgradeTo0_30CommandModule to include the new phone field migration
  • Removed UpgradeTo0_32CommandModule and related files, consolidating the upgrade process
  • Removed import and usage of UpgradeTo0_32CommandModule from DatabaseCommandModule

These changes streamline the upgrade process by incorporating the phone field migration into version 0.30 instead of 0.32, potentially simplifying future upgrades.

6 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Removing entire module for 0.32 upgrade. This action contradicts PR title about adding to 0.30. Verify if this removal is intentional and its impact on the upgrade process.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Deletion of 0.32 upgrade module may break dependencies. Ensure all references to this module are updated or removed throughout the codebase.

@bosiraphael bosiraphael merged commit 0e375d9 into main Sep 26, 2024
8 checks passed
@bosiraphael bosiraphael deleted the add-phone-fields-migration-command-to-0-30 branch September 26, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants