Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email migration script #7267

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fix email migration script #7267

merged 1 commit into from
Sep 26, 2024

Conversation

ijreilly
Copy link
Collaborator

No description provided.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request modifies the email migration script to improve the order of operations when upgrading email fields to the new emails type.

  • Reordered migration process in MigrateEmailFieldsToEmailsCommand to handle the standard person email field before custom fields
  • Moved migratePersonEmailFieldToEmailsField call to the beginning of the execution loop in packages/twenty-server/src/database/commands/upgrade-version/0-30/0-30-migrate-email-fields-to-emails.command.ts
  • Ensures consistent migration of the core person email field across all workspaces
  • Potential reduction in conflicts between standard and custom email field migrations

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Contributor

@bosiraphael bosiraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ijreilly ijreilly merged commit c1db435 into main Sep 26, 2024
8 checks passed
@ijreilly ijreilly deleted the fix-command-email branch September 26, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants