Add opened section #7265

thomtrp · 2024-09-26T09:45:48Z

When object is not part of the workspace favorite list, we want to show it in the "opened section" while its record page is accessed.

This PR:

adds a new component NavigationDrawerOpenedSection
makes workflow versions and runs not system object + creates a prefilled view index for these
do not create workspace favorites for these so these do not appear in the workspace section

greptile-apps

PR Summary

This pull request introduces an "opened section" in the navigation drawer for objects that are not part of the workspace favorite list. Here's a summary of the key changes:

Added new NavigationDrawerOpenedSection component to display objects not in workspace favorites
Created useObjectMetadataItemsInWorkspaceFavorites hook to efficiently manage workspace favorites
Modified data seeding process to exclude certain objects (workflow runs and versions) from workspace favorites
Introduced new views for workflow runs and versions, making them non-system objects
Updated WorkflowRunWorkspaceEntity and WorkflowVersionWorkspaceEntity to support the new navigation structure

Key points:

New getExcludedObjectMetadataIdsForFavoritesPrefill function controls which objects appear in workspace favorites
WorkspaceFavorites component simplified to use the new custom hook
Standard field IDs updated to include new fields for workflow runs and versions
Conditional rendering of the new opened section based on feature flag

_{15 file(s) reviewed, 4 comment(s)}
_{Edit PR Review Bot Settings}

...ages/twenty-front/src/modules/navigation/hooks/useObjectMetadataItemsInWorkspaceFavorites.ts

packages/twenty-front/src/modules/object-metadata/components/NavigationDrawerOpenedSection.tsx

...r/src/engine/workspace-manager/standard-objects-prefill-data/views/workflow-versions.view.ts

...ages/twenty-front/src/modules/navigation/hooks/useObjectMetadataItemsInWorkspaceFavorites.ts

packages/twenty-front/src/modules/object-metadata/components/NavigationDrawerOpenedSection.tsx

...es/twenty-server/src/engine/utils/get-excluded-object-metadata-ids-from-favorites-prefill.ts

...r/src/engine/workspace-manager/standard-objects-prefill-data/views/workflow-versions.view.ts

charlesBochet

LGTM!

When object is not part of the workspace favorite list, we want to show it in the "opened section" while its record page is accessed. This PR: - adds a new component `NavigationDrawerOpenedSection` - makes workflow versions and runs not system object + creates a prefilled view index for these - do not create workspace favorites for these so these do not appear in the workspace section <img width="1129" alt="Capture d’écran 2024-09-26 à 11 45 25" src="https://github.com/user-attachments/assets/c84d773c-0bef-4dce-b66a-55d7d00b0fb6">

greptile-apps bot reviewed Sep 26, 2024

View reviewed changes

thomtrp force-pushed the tt-add-navigation-item-for-active-view-if-not-exist branch from 81ec221 to 4da2d4f Compare October 1, 2024 13:38