Fixes #7105: Fixed column header on Kanban boards #7261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses issue #7105 by implementing a fixed column header for Kanban boards in the Twenty application.
- Added
position: fixedtoStyledHeaderContainerinRecordBoardColumnHeader.tsxto keep the header visible while scrolling - Set
height: 40pxfor the header container as per Figma specifications - Adjusted padding with
padding-top: 10pxto align with the desired layout - Potential issue: The fixed positioning may cause layout conflicts with other elements, requiring further adjustments
- Consider adding z-index to ensure the header stays on top of other elements when scrolling
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
| justify-content: space-between; | ||
| position: fixed; | ||
| width: 100%; |
There was a problem hiding this comment.
style: Width of 100% might extend beyond the column width. Consider using 'inherit' or a specific width
...odules/object-record/record-board/record-board-column/components/RecordBoardColumnHeader.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #7105 by fixing the column header on Kanban boards to ensure it remains fixed while scrolling.