Fixing last column width in table-view #7258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 25, 2024 20:23
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses issues with the last column width in the table view, focusing on improving layout and responsiveness.
- Modified
StyledTableinRecordTable.tsxto set width to 100%, fixing layout issues - Reduced width and max-width of table cells on mobile from 35px to 32px in
RecordTableTd.tsx - Adjusted styling of the last column in
RecordTableHeaderLastColumn.tsx, setting fixed width to 32px and removing left padding - Improved table responsiveness when wider than the screen, particularly affecting the last column
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
33
to
38
| ${({ isTableWiderThanScreen, theme }) => | ||
| isTableWiderThanScreen | ||
| ? ` | ||
| width: 32px; | ||
| background-color: ${theme.background.primary}; | ||
| ` | ||
| : ''}; |
There was a problem hiding this comment.
style: consider removing this conditional styling as it's now redundant with the background-color set on line 26
There was a problem hiding this comment.
fix this please!
we are setting background color on line 26 too!
@bosiraphael wait on merge please
There was a problem hiding this comment.
I'll pick this as cleanup in another PR @ehconitin
bosiraphael
approved these changes
Sep 25, 2024
ehconitin
reviewed
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #7160
table-layout: fixedrequires a width, added that.Screenshots:
Small screen: