[Phones migration](fix) update label of standard field by using raw query #7255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request updates the phone fields migration process, specifically focusing on updating the label of the standard person phone field using a raw SQL query.
- Modified
packages/twenty-server/src/database/commands/upgrade-version/0-32/0-32-migrate-phone-fields-to-phones.command.tsto use a raw query for updating the standard person phone field label - Replaced
fieldMetadataService.updateOne()with a direct SQL update statement to avoid potential side effects - Added error handling for the raw query execution to ensure robustness
- Improved migration reliability by bypassing service-level hooks and validations
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
Comment on lines
+184
to
+187
| await this.metadataDataSource.query( | ||
| `UPDATE "metadata"."fieldMetadata" SET "label" = $1 where "id"=$2`, | ||
| ['Phone (deprecated)', standardPersonPhoneField.id], | ||
| ); |
There was a problem hiding this comment.
logic: Using raw SQL query instead of fieldMetadataService. Ensure this doesn't bypass important logic or triggers.
Comment on lines
+259
to
+262
| await this.metadataDataSource.query( | ||
| `UPDATE "metadata"."fieldMetadata" SET "label" = $1 where "id"=$2`, | ||
| ['Phone', standardPersonPhoneField.id], | ||
| ); |
There was a problem hiding this comment.
style: Same raw SQL approach used here. Consider consistency with other field updates in the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.